ci: improve manual Github Action #2566
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable rd.debug for manual builds by default and allow changing it.
Test matrix for all tests is computed using "find" to.
LaszloGombos
force-pushed
the
mandebug
branch
13 times, most recently
from
66edc8b to
d4462d1
Compare
Test container names are discovered using "find" command. Add an option to specify container registry.
LaszloGombos
force-pushed
the
mandebug
branch
from
d4462d1 to
970352c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation is to help facilitate development of dracut using GitHub infra.
As the number of tests and number of containers grow, we could consider running less tests automatically on each PR and only run them on demand with the manual Github Action.
Running manual tests has the benefit of having the log available for everyone to see after the run, and saves the time of manually creating distro environments and uploading test logs.
1./ This commit enables setting environment variables before running the test. More specifically it sets rd.debug for manual builds by default, which can be turned off by simply clearing the "Enviroment" input (see screenshot below).
This change would allow to debug issues like #2225 on GitHub.
It also allows setting networking to e.g. systemd-networked ( {"USE_NETWORK": "systemd-networkd"} ) without changing a single line of code for e.g. #2141
2./ This commit allows to run all the test parallel. It uses "find" to compute the list of tests, so if we add new tests we do not need to update this list.
3./ This commit allows to run all test(s) in all containers in parallel using the new "all" entry. It uses "find" to compute the list of containers, so if we add new containers we do not need to update this list.