fix: bind on dualstack by default

both operator and dragonfly, should not hurt.
dragonflydb · Dec 8, 2024 · c572750 · c572750
1 parent 040d2ef
commit c572750
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/charts/dragonfly-operator/templates/deployment.yaml b/charts/dragonfly-operator/templates/deployment.yaml
@@ -36,8 +36,8 @@ spec:
         {{- toYaml .Values.podSecurityContext | nindent 8 }}
       containers:
         - args:
-            - --secure-listen-address=0.0.0.0:8443
-            - --upstream=http://127.0.0.1:8080/
+            - --secure-listen-address=[::]:8443
+            - --upstream=http://[::1]:8080/
             - --logtostderr=true
             - --v=0
           image: "{{ .Values.rbacProxy.image.repository }}:{{ .Values.rbacProxy.image.tag  }}"
@@ -55,7 +55,7 @@ spec:
         - name: manager
           args:
             - --health-probe-bind-address=:8081
-            - --metrics-bind-address=127.0.0.1:8080
+            - --metrics-bind-address=[::1]:8080
             - --leader-elect
           command:
             - /manager

diff --git a/config/default/manager_auth_proxy_patch.yaml b/config/default/manager_auth_proxy_patch.yaml
@@ -33,8 +33,8 @@ spec:
               - "ALL"
         image: gcr.io/kubebuilder/kube-rbac-proxy:v0.16.0
         args:
-        - "--secure-listen-address=0.0.0.0:8443"
-        - "--upstream=http://127.0.0.1:8080/"
+        - "--secure-listen-address=[::]:8443"
+        - "--upstream=http://[::1]:8080/"
         - "--logtostderr=true"
         - "--v=0"
         ports:
@@ -51,5 +51,5 @@ spec:
       - name: manager
         args:
         - "--health-probe-bind-address=:8081"
-        - "--metrics-bind-address=127.0.0.1:8080"
+        - "--metrics-bind-address=[::]:8080"
         - "--leader-elect"
diff --git a/internal/resources/const.go b/internal/resources/const.go
@@ -69,6 +69,8 @@ const (
 var DefaultDragonflyArgs = []string{
 	"--alsologtostderr",
 	"--primary_port_http_enabled=false",
+	"--bind=::",
+	"--admin_bind=::",
 	fmt.Sprintf("--admin_port=%d", DragonflyAdminPort),
 	"--admin_nopass",
 }
diff --git a/manifests/dragonfly-operator.yaml b/manifests/dragonfly-operator.yaml
@@ -2072,8 +2072,8 @@ spec:
                 - linux
       containers:
       - args:
-        - --secure-listen-address=0.0.0.0:8443
-        - --upstream=http://127.0.0.1:8080/
+        - --secure-listen-address=[::]:8443
+        - --upstream=http://[::1]:8080/
         - --logtostderr=true
         - --v=0
         image: gcr.io/kubebuilder/kube-rbac-proxy:v0.16.0
@@ -2096,7 +2096,7 @@ spec:
             - ALL
       - args:
         - --health-probe-bind-address=:8081
-        - --metrics-bind-address=127.0.0.1:8080
+        - --metrics-bind-address=[::]:8080
         - --leader-elect
         command:
         - /manager