fix(updates): re-run loop when update is made #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pothulapati
force-pushed
the
tar/missing-updates
branch
from
11f3da8 to
28b25da
Compare
Pothulapati
force-pushed
the
tar/missing-updates
branch
5 times, most recently
from
2138acb to
02fe5ec
Compare
Currently, We sometimes miss updates when we compare the statefulset version. This could be stale as update couldn't have propogated already. This PR fixes that by requeuing the object when an update is made, so that we retreive the latest version when ran again.
Pothulapati
force-pushed
the
tar/missing-updates
branch
from
a8848c5 to
b248be4
Compare
Pothulapati
changed the title
Pothulapati
commented
Oct 18, 2023
| @@ -446,6 +451,46 @@ var _ = Describe("Dragonfly Lifecycle tests", Ordered, FlakeAttempts(3), func() | |||
|
|
|||
| // check for affinity | |||
| Expect(ss.Spec.Template.Spec.Affinity.NodeAffinity.PreferredDuringSchedulingIgnoredDuringExecution).To(Equal(newAffinity.NodeAffinity.PreferredDuringSchedulingIgnoredDuringExecution)) | |||
|
|
|||
There was a problem hiding this comment.
This is important as it actually verifies if the statefulset update actually translated into a rollout onto the pods.
Pothulapati
commented
Oct 18, 2023
| @@ -59,7 +59,7 @@ vet: ## Run go vet against code. | |||
| .PHONY: test | |||
| test: manifests generate fmt vet envtest ## Run tests. | |||
| GOBIN=$(LOCALBIN) go install github.com/onsi/ginkgo/v2/[email protected] | |||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" $(GINKGO) -r -p -coverprofile cover.out | |||
| KUBEBUILDER_ASSETS="$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) --bin-dir $(LOCALBIN) -p path)" $(GINKGO) -vv -r -p -coverprofile cover.out | |||
There was a problem hiding this comment.
adds more verbose logs on the tests
Pothulapati
commented
Oct 18, 2023
| @@ -609,12 +654,20 @@ var _ = Describe("Dragonfly Server TLS tests", Ordered, FlakeAttempts(3), func() | |||
| TLSSecretRef: &corev1.SecretReference{ | |||
| Name: "df-tls", | |||
| }, | |||
| Authentication: &resourcesv1.Authentication{ | |||
There was a problem hiding this comment.
This is needed as an auth mechanism is necessary when we pass a TLS certificate.
Abhra303
approved these changes
Oct 18, 2023
ashotland
approved these changes
Oct 18, 2023
diffuse
pushed a commit
to diffuse/dragonfly-operator
that referenced
this pull request
Nov 18, 2023
* fix(updates): re-run loop when update is made Currently, We sometimes miss updates when we compare the statefulset version. This could be stale as update couldn't have propogated already. This PR fixes that by requeuing the object when an update is made, so that we retreive the latest version when ran again. * fix comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93
Currently, We sometimes miss updates when we compare the statefulset
version. This could be stale as update couldn't have propogated already.
This PR fixes that by requeuing the object when an update is made, so
that we retreive the latest version when ran again.