Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reconciler): recreate missing resources #222

Merged
merged 8 commits into from
Dec 3, 2024
Merged

fix(reconciler): recreate missing resources #222

merged 8 commits into from
Dec 3, 2024

Conversation

Abhra303
Copy link
Contributor

@Abhra303 Abhra303 commented Jul 23, 2024

Fixes #138
Fixes #165

@Pothulapati Pothulapati self-requested a review August 14, 2024 07:28
@Abhra303 Abhra303 force-pushed the ac/fix branch 8 times, most recently from b2eb867 to 1055eab Compare August 20, 2024 06:29
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Copy link
Collaborator

@Pothulapati Pothulapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the comment.

internal/controller/dragonfly_controller.go Outdated Show resolved Hide resolved
Signed-off-by: Abhradeep Chakraborty <[email protected]>
@Abhra303 Abhra303 requested a review from Pothulapati December 2, 2024 11:07
@Abhra303 Abhra303 merged commit 4012589 into main Dec 3, 2024
4 checks passed
@Abhra303 Abhra303 deleted the ac/fix branch December 3, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statefulset update / recreate controller stuck when rollout fails
2 participants