fix(search): Support indexing array paths #2074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
force-pushed
the
search-arrays
branch
from
686ff32 to
0392f42
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
search-arrays
branch
from
0392f42 to
ea3dabd
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
chakaz
reviewed
Oct 27, 2023
| StringList out; | ||
| for (auto element : path_res.array_range()) { | ||
| size_t start = buf_.size(); | ||
| buf_ += element.as_string(); |
There was a problem hiding this comment.
This could invalidate all previous string_views in out, no?
Is there anything in line 124 that prevents growing again?
There was a problem hiding this comment.
No 😆 I forgot to use my brain
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
search-arrays
branch
from
9bb8273 to
5e11093
Compare
Signed-off-by: Vladislav Oleshko <[email protected]>
chakaz
reviewed
Oct 27, 2023
|
Hey @dranikpg, I'm not sure if you're ready for another review? |
Signed-off-by: Vladislav Oleshko <[email protected]>
dranikpg
force-pushed
the
search-arrays
branch
from
bde121c to
6ca1643
Compare
chakaz
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes one of the issues discussed in #1995 with arrays not being indexed