chore: simplify expired flow in StringFamily::Set #3643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kostas <[email protected]>
adiholden
reviewed
Sep 4, 2024
| // past time | ||
| at_ms = op_args_.db_cntx.time_now_ms - 1; | ||
| } | ||
|
|
||
| if (!(params.flags & SET_KEEP_EXPIRE)) { | ||
| if (at_ms) { // Command has an expiry paramater. | ||
| if (IsValid(e_it)) { |
There was a problem hiding this comment.
where do we delete the entry in this flow? can you point to the flow
|
I am closing this since the changes appears to be subjective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the time argument of
SETcommand is already expired we scheduled a transaction that deleted the (if existed) element that the set command would replace. This was not really needed as the logic around expired values already handles this case. Bonus points is that we also now don't schedule a different transaction (OpDel) when we parse the arguments (and let the normal flow continue)