fix: ExtentTree use of invalidated iterator #4416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostasrim
commented
Jan 7, 2025
| @@ -29,7 +29,7 @@ void ExtentTree::Add(size_t start, size_t len) { | |||
| prev->second += len; | |||
| start = prev->first; | |||
| len += prev_len; | |||
| prev_extent = prev; | |||
| prev_extent_key = prev->first; | |||
There was a problem hiding this comment.
absl also issued a warning but the test did not fail. Maybe we should somehow be aware of these warnings (because they usually point to the root cause of the problem)
|
I thought it's fully compatible with |
romange
approved these changes
Jan 7, 2025
romange
pushed a commit
that referenced
this pull request
Jan 12, 2025
Fixes accessing and invalidated iterator within ExtendTree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in https://github.com/dragonflydb/dragonfly/blob/main/src/core/extent_tree.cc#L41 do not considerate that the cached iterator might be invalidated by the erase() above. As such, it causes an illegal access and it was caught by the sanitizers: https://github.com/dragonflydb/dragonfly/actions/runs/12644997917/job/35233466191#step:8:8607