feat(docker): push dragonfly image to gcp artifact registry #4716
+211
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
Signed-off-by: Abhradeep Chakraborty <[email protected]>
romange
reviewed
Mar 7, 2025
| uses: docker/login-action@v3 | ||
| with: | ||
| registry: us-central1-docker.pkg.dev | ||
| username: _json_key |
There was a problem hiding this comment.
does it have to be _json_key ? Can we have a user "github_actions" for example?
romange
reviewed
Mar 7, 2025
|
|
There was a problem hiding this comment.
seems like lots of code duplication. Can you introduce a bash function that runs docker manifest create and push?
romange
reviewed
Mar 7, 2025
| fi | ||
| echo "Redis ping succeeded" | ||
|
|
||
| for image_tag in "${image_tags[@]}"; do |
There was a problem hiding this comment.
really not an expert. can we build images like before and just create and push manifests to both registries in the end?
why do we need to change anything here?
romange
reviewed
Mar 7, 2025
| @@ -0,0 +1,161 @@ | |||
| name: Docker Release to GCS Artifact Registry | |||
There was a problem hiding this comment.
why we needed to duplicate the release pipeline? can we just do it in the last step of docker-release2?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4603. I have tested the docker-dev-release.yml. Not sure how to test the docker-release-artifact-registry.yml workflow. Do I have to open the PR from
dragonflydb/dragonflyrepo to test the workflow?I also need to add gcp service account key in the repo secrets.