Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: exclude local files changes from git staging #4733

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

vyavdoshenko
Copy link
Contributor

@vyavdoshenko vyavdoshenko commented Mar 9, 2025

chore: added script to ignore local file changes in files mentioned in .gitignore but still shown as changed
docs: CONTRIBUTING.md has been updated
docs: tools/local/SETUP_GIT_IGNORE_LOCAL.md was added

@vyavdoshenko vyavdoshenko requested a review from adiholden March 9, 2025 11:47
@romange
Copy link
Collaborator

romange commented Mar 9, 2025

Curious, how it is better than .gitignore? in any case, we put utilities that help local development under tools/local

@vyavdoshenko
Copy link
Contributor Author

Curious, how it is better than .gitignore? in any case, we put utilities that help local development under tools/local

@romange
These files are in .gitignore added before me. That doesn't help, I verified that on two dev environments. It worked via .gitignore in the past. I used that by simply adding files to the .gitignore. It doesn't work any longer. I guess modern git versions don't support this approach.
That's why I suggest this solution.

@romange
Copy link
Collaborator

romange commented Mar 9, 2025

interesting, what does not work with .gitignore? It works on my machine - i just changed .vscode/settings.json and it does not show locally.

@vyavdoshenko
Copy link
Contributor Author

interesting, what does not work with .gitignore? It works on my machine - i just changed .vscode/settings.json and it does not show locally.

Screenshot 2025-03-09 at 16 19 33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants