[wip] feat(metrics): Add label for main and other listeners #4739
+96
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijat
force-pushed
the
abhijat/feat/label-for-main-listener
branch
3 times, most recently
from
cfcc57c to
8139a83
Compare
The stats collected per connection are divided according to main or other listener. Metrics are decorated with labels listener= main or other. Signed-off-by: Abhijat Malviya <[email protected]>
abhijat
force-pushed
the
abhijat/feat/label-for-main-listener
branch
from
8139a83 to
6321b86
Compare
| @@ -700,14 +700,18 @@ void Connection::OnPostMigrateThread() { | |||
| } | |||
|
|
|||
| stats_ = &tl_facade_stats->conn_stats; | |||
| ++stats_->num_conns; | |||
| IsMain() ? ++stats_->num_conns_main : ++stats_->num_conns_other; | |||
There was a problem hiding this comment.
Since it repeated several times I suggest return something like uint32_t& GetNumConns() and do ++GetNumConns() or --GetNumConns()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stats collected per connection are divided according to main or other listener.
Metrics are decorated with labels listener= main or other.
fixes #4708