Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release-draft): adopt new download/upload artifact api #2133

Merged
merged 1 commit into from
Jan 22, 2025
Merged

fix(release-draft): adopt new download/upload artifact api #2133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 6 additions & 20 deletions .github/workflows/release-draft.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
fetch-depth: 0

- name: Install deps
run: |

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:28:47: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2046:warning:28:47: Quote this to prevent word splitting [shellcheck]

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:28:59: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2086:info:28:59: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:29:20: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2046:warning:29:20: Quote this to prevent word splitting [shellcheck]

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:29:32: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2086:info:29:32: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:30:17: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2046:warning:30:17: Quote this to prevent word splitting [shellcheck]

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:30:29: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2086:info:30:29: Double quote to prevent globbing and word splitting [shellcheck]

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2046:warning:31:14: Quote this to prevent word splitting [shellcheck]

Raw Output:
w:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2046:warning:31:14: Quote this to prevent word splitting [shellcheck]

Check warning on line 40 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:31:26: Double quote to prevent globbing and word splitting [shellcheck]

Raw Output:
i:.github/workflows/release-draft.yaml:40:9: shellcheck reported issue in this script: SC2086:info:31:26: Double quote to prevent globbing and word splitting [shellcheck]
cp -v scripts/zig-cc /usr/bin/
cp -v scripts/zig-c++ /usr/bin/
apt update && \
Expand Down Expand Up @@ -214,13 +214,13 @@
PRIVATE_KEY: ${{ secrets.SYSDIG_REPO_SIGNING_KEY }}
run: printenv PRIVATE_KEY | gpg --import -
- name: Sign RPMs
run: rpm --define "_gpg_name ${{ env.KEY_ID }}" --define "_binary_filedigest_algorithm 8" --addsign *.rpm

Check warning on line 217 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2035:info:1:96: Use ./*glob* or -- *glob* so names with dashes won't become options [shellcheck]

Raw Output:
i:.github/workflows/release-draft.yaml:217:9: shellcheck reported issue in this script: SC2035:info:1:96: Use ./*glob* or -- *glob* so names with dashes won't become options [shellcheck]
- name: Check signature
run: test "$(rpm -qpi *.rpm | awk '/Signature/' | grep -i none | wc -l)" -eq 0

Check warning on line 219 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2035:info:1:18: Use ./*glob* or -- *glob* so names with dashes won't become options [shellcheck]

Raw Output:
i:.github/workflows/release-draft.yaml:219:9: shellcheck reported issue in this script: SC2035:info:1:18: Use ./*glob* or -- *glob* so names with dashes won't become options [shellcheck]

Check failure on line 219 in .github/workflows/release-draft.yaml

View workflow job for this annotation

GitHub Actions / actionlint 

[actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2126:style:1:46: Consider using 'grep -c' instead of 'grep|wc -l' [shellcheck]

Raw Output:
e:.github/workflows/release-draft.yaml:219:9: shellcheck reported issue in this script: SC2126:style:1:46: Consider using 'grep -c' instead of 'grep|wc -l' [shellcheck]
- name: Upload Signed RPMs
uses: actions/upload-artifact@v4
with:
name: sysdig-release-${{ env.BUILD_VERSION }}-${{ matrix.arch }}
name: sysdig-release-${{ env.BUILD_VERSION }}-${{ matrix.arch }}-rpms
path: "*.rpm"

sign-debs:
Expand Down Expand Up @@ -261,33 +261,19 @@
- name: Upload Signed DEBs
uses: actions/upload-artifact@v4
with:
name: sysdig-release-${{ env.BUILD_VERSION }}-${{ matrix.arch }}
name: sysdig-release-${{ env.BUILD_VERSION }}-${{ matrix.arch }}-debs
path: "*.deb"

create-draft-release:
runs-on: ubuntu-latest
needs: [push-container-image, build-release-linux, sign-rpms, sign-debs]
steps:
- name: Download artifacts (linux-amd64)
- name: Download all artifacts
uses: actions/download-artifact@v4
with:
name: sysdig-release-${{ env.BUILD_VERSION }}-x86_64
- name: Download artifacts (linux-arm64)
uses: actions/download-artifact@v4
with:
name: sysdig-release-${{ env.BUILD_VERSION }}-aarch64
- name: Download artifacts (win-amd64)
uses: actions/download-artifact@v4
with:
name: sysdig-release-${{ env.BUILD_VERSION }}-win-x86_64
- name: Download artifacts (osx-amd64)
uses: actions/download-artifact@v4
with:
name: sysdig-release-${{ env.BUILD_VERSION }}-osx-x86_64
- name: Download artifacts (osx-arm64)
uses: actions/download-artifact@v4
with:
name: sysdig-release-${{ env.BUILD_VERSION }}-osx-arm64
pattern: sysdig-release-${{ env.BUILD_VERSION }}*
merge-multiple: true

- name: Create draft release
uses: softprops/action-gh-release@v2
with:
Expand Down
Loading