Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Status in schema #35

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Updated Status in schema #35

merged 2 commits into from
Dec 19, 2024

Conversation

thisistheplace
Copy link
Contributor

@thisistheplace thisistheplace commented Dec 18, 2024

Hi,

I've updated the Status model in the Schema to match the number type in the Fronius API docs, and removed it from the PvSystem model (since it's not a field in the Fronius docs).

Thanks,

Ben

@drc38
Copy link
Owner

drc38 commented Dec 19, 2024

Hi @thisistheplace

Can you provide api references for these changes please. From the Api pdf it shows the following:

{ "pvSystemId": "04d81b82-7861-4e36-8e7f-41036ce711a4", "status": { "isOnline": true, "battMode": "1.0"  }, "data": { "logDateTime": "2019-06-18T14:01:57Z", "channels": [      { "channelName": "PowerFeedIn", "channelType": "Power", "unit": "W", "value": -496.01      },      { "channelName": "PowerLoad", "channelType": "Power", "unit": "W",

@thisistheplace
Copy link
Contributor Author

thisistheplace commented Dec 19, 2024

Hi @drc38,

I've been using the EnergyFlowStatus schema here as a reference:
https://api.solarweb.com

Strange that the pdf example suggests that the status.battMode field is a string, whereas the return type from the API Schema is actually a number($double). Although in page 81 it states that the type is a number($double).

There seems to be a discrepancy in the pdf docs (status.battMode field type) between the example response output on page 82 and page 85. I'm inclined to believe the Swagger docs rather than the pdf though.

What do you think?

@drc38
Copy link
Owner

drc38 commented Dec 19, 2024

Hi @drc38,

I've been using the EnergyFlowStatus schema here as a reference: https://api.solarweb.com

Strange that the pdf example suggests that the status.battMode field is a string, whereas the return type from the API Schema is actually a number($double). Although in page 81 it states that the type is a number($double).

There seems to be a discrepancy in the pdf docs (status.battMode field type) between the example response output on page 82 and page 85. I'm inclined to believe the Swagger docs rather than the pdf though.

What do you think?

Thanks, could you update the PR so battMode is [float | str] just in case the api changed at some point and there's still firmware sending a string. Otherwise LGTM.

Thanks for your PRs

@thisistheplace
Copy link
Contributor Author

That's done. Thanks for writing the package!

@drc38 drc38 merged commit 32109b0 into drc38:main Dec 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants