Fixes and improvements for achievement notifications.

[drgrice1]

The $mail{achievementEmailFrom} setting was not working because in the task it tried to use a non-existent $mail{achievementEmailSender} variable.

Make it so that achievement notifications are only sent if $mail{achievementEmailFrom} is set, and do NOT fall back to using $mail{smtpSender} or $$mail{set_return_path}. Those are not valid for this in any way.

Make the default template only remark on the number of points remaining until the next level-up if $nextLevelPoints is set. It is likely that a non-level achievement will occur before the first level achievement (for example if both of the one_click and level_one achievements are enabled, and the student gets the first question correct in one attempt) in which case the next level points has not been set yet. If that happens then the email says there are a negative number of points remaining until the next level-up.

Add a help file for the achievement notification editor page.

On the achievement list page, make the "Notifications" column say "Edit Email Template $templateName" if an email notification template is enabled for the achievement as requested by @somiaj. I would be happy with reverting this though as it can make this column rather wide.

Remove all of the radio options in the "Save As" form, and just assume it is being saved for the current achievement. I don't really see the need for any of those options.

Add the [ACHEVDIR] prefix to the "Save As" form, and add dir => 'ltr' to file names since those don't work right in right to left languages otherwise.

In the site navigation when editing an achievement evaluator, an achievement notification, or the achievement users, show sub links for all of those editors.

Change the text_field in the existing_form.html.ep to a select_field that shows all of the existing template files.

Don't use the WeBWorK::Utils::processEmailMessage method. I see no reason for that. There is not actually any merge data, so in reality this is only used to get the user's first name and potentially other information from the user record. That can be passed directly to the template and used there, so that is done instead. The default template is modified accordingly.

Lots of clean up of the AchievementNotificationEditor.pm file and the AchivievementNotification.pm file.

Instead of storing achievement email notification templates in the course templates/achievements directory directly, store them in templates/achievements/notifications subdirectory. This directory is added to the list of directories in the updateCourseDirectories method of WeBWorK::Utils::CourseIntegrityCheck that can be copied from the modelCourse. This has a couple of advantages. First, most courses will not have this directory so if the modelCourse is updated, then this directory will be copied and get the default template when the course is upgraded from the admin course. Second, it separates the achievement evaluator files from the achievement notification templates.

[drdrew42]

@drgrice1 these are all excellent changes. I'm not sure I agree with including the template name in the table, as you mentioned, it can make the corresponding column unnecessarily wide. I don't feel super-strongly about it, so I'll go with the consensus.

[somiaj]

@drdrew42 You should probably just merge these in your branch (vs approve them).

Also don't keep the template name on my account, I use a wide screen so I saw extra space that could be used, but forgot about narrow screens. I just thought it might be useful to have a bit more info in that column, but it isn't necessary.