Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix regression in continue on error #28

Conversation

GangGreenTemperTatum
Copy link
Collaborator

@GangGreenTemperTatum GangGreenTemperTatum commented Nov 28, 2024

AI-Generated Summary

PR Summary

Overview of Changes

This PR introduces modifications to the .github/workflows/validate_robopages.yml file to enhance the validation process for contribution files. The changes focus on modifying the validation scripts to better capture and handle validation status while also improving how validation results are communicated within GitHub Actions.

Key Modifications

  1. Enhanced Error Handling: The validation process now captures the exit status of each validation attempt, which allows for improved error reporting.
  2. Overall Validation Status: Introduced an overall_status variable to aggregate the validation status of all files checked. This allows the workflow to exit with a status indicative of the validation process's collective outcome.
  3. Updated GitHub Actions Communication: The mechanism for posting the validation status has been updated from creating a pull request review to creating an issue comment. This change might impact how contributors receive feedback on validation.
  4. Removed continue-on-error: The directive continue-on-error: true was removed, shifting towards handling errors within the script to decide on the workflow's exit code.

Potential Impact

  • Improved clarity and immediate feedback on the validation status of contributed .yml files, potentially reducing the number of iterations required to meet contribution guidelines.
  • Changes in how validation failures are reported could alter the workflow for contributors and maintainers, impacting how errors are addressed.
  • The removal of continue-on-error in favor of script-managed error handling provides a more nuanced approach to dealing with validation failures, likely impacting the overall robustness of the validation process.

This summary was generated with ❤️ by rigging

@GangGreenTemperTatum GangGreenTemperTatum requested a review from a team as a code owner November 28, 2024 15:30
@GangGreenTemperTatum
Copy link
Collaborator Author

fixes regression from here regression from #24

Copy link

Validation Results (2024-11-28T15:48:47.327Z)

❌ Validation failed

Please ensure your contribution follows the required format.

View Full Validation Details


Run ID: 12072047521
Workflow: Validate Contributions

@GangGreenTemperTatum
Copy link
Collaborator Author

@evilsocket tested and confirmed ready for review, please can you approve so i can merge this in?

@evilsocket evilsocket merged commit 5965ed1 into main Nov 29, 2024
1 check passed
@evilsocket evilsocket deleted the ads/eng-323-bug-regression-in-robopages-workflow-validation-failures branch November 29, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants