fix: fix regression in continue on error #28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AI-Generated Summary
PR Summary
Overview of Changes
This PR introduces modifications to the
.github/workflows/validate_robopages.yml
file to enhance the validation process for contribution files. The changes focus on modifying the validation scripts to better capture and handle validation status while also improving how validation results are communicated within GitHub Actions.Key Modifications
overall_status
variable to aggregate the validation status of all files checked. This allows the workflow to exit with a status indicative of the validation process's collective outcome.continue-on-error
: The directivecontinue-on-error: true
was removed, shifting towards handling errors within the script to decide on the workflow's exit code.Potential Impact
.yml
files, potentially reducing the number of iterations required to meet contribution guidelines.continue-on-error
in favor of script-managed error handling provides a more nuanced approach to dealing with validation failures, likely impacting the overall robustness of the validation process.This summary was generated with ❤️ by rigging