Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ui part can replace #4033

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

ybzky
Copy link
Member

@ybzky ybzky commented Nov 11, 2024

close #xxx

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

Copy link

github-actions bot commented Nov 11, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

passed  19 passed

Details

stats  19 tests across 9 suites
duration  4 minutes, 39 seconds
commit  bf412db
info  For more information, see full report

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 32.85%. Comparing base (d793188) to head (bf412db).
Report is 15 commits behind head on dev.

Files with missing lines Patch % Lines
packages/ui/src/services/parts/parts.service.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4033      +/-   ##
==========================================
+ Coverage   32.84%   32.85%   +0.01%     
==========================================
  Files        2501     2501              
  Lines      126541   126595      +54     
  Branches    28338    28351      +13     
==========================================
+ Hits        41566    41598      +32     
- Misses      84975    84997      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@wzhudev wzhudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some discussions with @ybzky, we should try to provide config instead of this API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants