Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formula): some formulas need to be tested in dev #4116

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

wpxp123456
Copy link
Contributor

@wpxp123456 wpxp123456 commented Nov 21, 2024

test in https://univer-preview.vercel.app/sheets/

  • ROUNDBANK
  • ISBETWEEN
  • AVERAGE.WEIGHTED
  • MARGINOFERROR
  • ISEMAIL
  • ISURL
  • ENCODEURL
  • EPOCHTODATE
  • TO_DATE
  • ISDATE
  • LINEST
  • LOGEST
  • TREND
  • ARRAY_CONSTRAIN
  • FLATTEN
  • IMCOTH
  • IMLOG
  • IMTANH

Pull Request Checklist

  • Related tickets or issues have been linked in the PR description (or missing issue).
  • Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
  • Unit tests have been added for the changes (if applicable).
  • Breaking changes have been documented (or no breaking changes introduced in this PR).

@wpxp123456 wpxp123456 added the qa:untested This PR is ready to be tested label Nov 21, 2024
Copy link

github-actions bot commented Nov 21, 2024

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link

Copy link

Playwright test results

failed  1 failed
passed  19 passed

Details

stats  20 tests across 9 suites
duration  5 minutes, 46 seconds
commit  3b3bd47
info  For more information, see full report

Failed tests

chromium › memory/memory.spec.ts › memory

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.79%. Comparing base (0dc0027) to head (3b3bd47).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #4116   +/-   ##
=======================================
  Coverage   33.79%   33.79%           
=======================================
  Files        2457     2457           
  Lines      127593   127593           
  Branches    28562    28562           
=======================================
  Hits        43126    43126           
  Misses      84467    84467           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qa:untested This PR is ready to be tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant