Fix for onServerSearch
and labelRenderer
#666
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue mentioned in #664 and replaces #665.
I did not use
eval(...)
as suggested because I found on the internet that it might cause security issues. Because of that, I chose thewindow[...]
approach. One notable drawback of this implementation is that the functions that will be used (passed in theonServerSearch
parameter) must be defined outside of any document.ready statement.I also updated the docs, NEWS.md and version.
Sorry if the news/version update is overboard - feel free to fix it or LMK and I'll create a new PR :)
Thanks!