Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the CI workflow #252

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Improve the CI workflow #252

merged 2 commits into from
Dec 4, 2024

Conversation

bcmeireles
Copy link
Contributor

Summary

Made some improvements to our CI workflow

Description

  • Broke down the steps in the pipeline into different bash scripts for readability and local reproducibility
  • Setting environment variables using the correct approach for action jobs
  • Credentials (even dummy) handled through secrets

Test Results

N/A

Changelog

  • Created scripts inside .github/scripts
  • Updated .github/ci.yml

Related Issue

#39
This improves #248

@bcmeireles bcmeireles self-assigned this Dec 4, 2024
@bcmeireles bcmeireles merged commit d0bbf49 into dremio:main Dec 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpannek simonpannek simonpannek approved these changes

@howareyouman howareyouman howareyouman approved these changes

Assignees

@bcmeireles bcmeireles

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bcmeireles @howareyouman @simonpannek