Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove secrets and use dummy values #254

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

bcmeireles
Copy link
Contributor

Summary

Removed the need for secrets usage

Description

Removed the usage of secrets since they are not passed to workflows that are triggered by a pull request from a fork

These are dummy values since we setup and deploy instances locally in the pipeline itself

Test Results

N/A

Changelog

  • moved dummy values out of secrets in .github/workflows/ci.yml

Related Issue

N/A

@bcmeireles bcmeireles merged commit 790a6a4 into dremio:main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants