Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transactions #29

Merged
merged 11 commits into from
Mar 9, 2023
Merged

Transactions #29

merged 11 commits into from
Mar 9, 2023

Conversation

bartvanhoutte
Copy link
Contributor

PR adding transactions to Connection. See #28 for more information.

@bartvanhoutte bartvanhoutte marked this pull request as ready for review July 8, 2022 14:12
@bartvanhoutte
Copy link
Contributor Author

Haven't added logging yet as being discussed in #28 .

@marinhekman
Copy link
Contributor

@mmoreram

@bartvanhoutte I tested our project on your branch , and did not encounter any issues. To be clear, we do not use any transactions , so using drift react without it still works .
If you test the transaction parts, and me and @mmoreram have reviewed the code, I think we can merge this into master. @mmoreram ?
There was still some psr logging to work on ? Let's go to php 8 , we already moved to 8.1 here as well.

Marc, have you seen my last message?
I think we can merge this branch for transaction support

@mmoreram mmoreram merged commit ea83ca5 into driftphp:master Mar 9, 2023
@mmoreram
Copy link
Member

mmoreram commented Mar 9, 2023

Sorry, I've been completely out with my project.
I've rebased and merged this.
Good work, and sorry for forgetting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bartvanhoutte @marinhekman @mmoreram