Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: funder list stored locally #638

Closed
wants to merge 1 commit into from
Closed

Conversation

evvvritt
Copy link
Collaborator

  • minimal implementation (using z.any() / no type checking)
  • clears stored if local is corrupted or doesn't match state (cheap check)

should we remove the "changes may not be saved" page reload popup guard?
(if so, where is that?)

@evvvritt evvvritt requested a review from efstajas August 28, 2023 18:32
@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for drips-app-v2 ready!

Name Link
🔨 Latest commit 6925964
🔍 Latest deploy log https://app.netlify.com/sites/drips-app-v2/deploys/64ece838e741a5000878f61c
😎 Deploy Preview https://deploy-preview-638--drips-app-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evvvritt
Copy link
Collaborator Author

ah, the e2e fails because we can't save the stream value as a bigint (fails when storedWriteable tries to stringify it)

i guess an idea is to just store the dripList as a storedWriteable copy of the steppers writeable state? and load it if it's present?
(refresh loads at the drip list editor anyways)

or is it important to save the stream inputs?

@evvvritt evvvritt marked this pull request as draft August 29, 2023 14:57
@evvvritt
Copy link
Collaborator Author

@efstajas wdyt^?

@evvvritt evvvritt closed this Jan 23, 2024
@evvvritt evvvritt deleted the ev/drip-list-stored branch January 23, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant