Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ev/iss629 #641

Merged
merged 29 commits into from
Sep 8, 2023
Merged

Ev/iss629 #641

merged 29 commits into from
Sep 8, 2023

Conversation

evvvritt
Copy link
Collaborator

@evvvritt evvvritt commented Aug 29, 2023

items from #629

Edit Drip List Modal

  • Change primary button on modal to "Confirm changes in your wallet" (GLOBAL / ALL OCCURENCES)

Streams page

see PR #639

Global

  • Disable the font style setting that makes the "x" character be positioned in the middle of the Cap height when it's between two numbers. i.e. 0x4 shows up as 0×4, when it should show up as 0x4.
  • Make "Cancel" button a ghost button on modals instead of a outline button
  • Make users confirm clicking out of a flow, replace X button with Cancel buttons #656
  • the chevron on the dropdown component should be foreground, not level 4

Add funds modal

  • the token ticker symbol should be grey-4 instead of foreground
  • placeholder text should be "Search tokens" instead of just "Search"

Add USDC funds modal

  • "Wallet Balance" balance shouldn't be capitalized
  • instead of "Go back" change text to "Back" (GLOBAL)

Single stream page

Create stream modal

  • The text "Specify start- and end dates" shouldn't have a hyphen.

Profile

  • Change the meta data icons color to foreground instead of level-4

Project page

  • bold the eth address before "is raising funds for" so that it matches the "created a Drip List" heading on the Drip List page. these already match but aren't bold?

Account Dropdown

  • Make the disconnect button a ghost button. takes too much focus being a normal button (ALSO REMOVED X ICON)
  • make the dividers foreground

BONUS

  • initial height matches input (if exists) max 200px high - (see on Edit Drip List modal)
  • Drip Lists dashboard - updated Dismissable to have Dismiss button + new copy

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for drips-app-v2 ready!

Name Link
🔨 Latest commit 2668c03
🔍 Latest deploy log https://app.netlify.com/sites/drips-app-v2/deploys/64fa12c1e6431700081cab98
😎 Deploy Preview https://deploy-preview-641--drips-app-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@evvvritt evvvritt marked this pull request as ready for review September 6, 2023 16:11
@brandonhaslegs
Copy link
Collaborator

brandonhaslegs commented Sep 7, 2023

Can you also add a "Dismiss" button here and remove the X? Just like the other informational cards across the app?

image

@evvvritt
Copy link
Collaborator Author

evvvritt commented Sep 7, 2023

yep, updated:
Screenshot 2023-09-07 at 15 31 03

@evvvritt evvvritt merged commit e4c2977 into main Sep 8, 2023
10 checks passed
@evvvritt evvvritt deleted the ev/iss629 branch September 8, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants