truncate (...) long project name (closes #540) #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@brandonhaslegs wdyt of the design?
|
evvvritt
changed the title
|
ah, need to fix one more truncate instance (in claim project modal slot) |
|
I (annoyingly, sorry) don't think we should truncate the project name! it should flow to the next line. Otherwise you can't fully read it anywhere. |
|
Ok, I removed the truncate on the big project title in the header, but keeping it the badge. Good @brandonhaslegs? 
|
brandonhaslegs
approved these changes
Sep 20, 2023
efstajas
requested changes
Sep 21, 2023
src/routes/app/(flows)/funder-onboarding/steps/build-list/build-list.svelte
Outdated
Show resolved
Hide resolved
|
@evvvritt could you check why the tests are failing? Edit.: they no longer are. Reviewing now 😁 |
efstajas
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #540
screenshots below (note, Edit button properly only applies for owner*)