refactor: use coinmarketcap to generate static fiat estimates #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
efstajas
commented
Sep 16, 2023
jtourkos
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Code looks good 👍
Just a thing I noticed while testing locally:
If you manually refresh the page (I was testing http://localhost:5173/app/projects/github/libgit2/libgit2), you sometimes get the estimation, but some other times you get:
Uncaught (in promise) Error: Token info not found for tracked token
at assert (assert.ts:9:11)
at Object.convert (fiat-estimates.ts:139:3)
at token-amounts-table.svelte:37:49
at Array.forEach (<anonymous>)
at $$self.$$.update (token-amounts-table.svelte:36:13)
at update (index.mjs:1343:12)
at flush (index.mjs:1307:17)
Comment on lines
+9
to
+10
| type TokenAddress = string; | ||
| type DataProviderTokenId = number; |
There was a problem hiding this comment.
Not for this PR: In case you want to take this further, check branded types. 🤓
There was a problem hiding this comment.
nice, never heard of this before!
|
@jtourkos great catch, I think I know why it's happening. Will push a fix shortly |
…claim project flow
jtourkos
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the Binance WS endpoint isn't accessible globally, so this PR changes our provider for fiat estimates to the Coinmarketcap API.
Important: Adds a new env variable
COINMARKETCAP_API_KEY. To get one for local development, sign up for a free developer account with Coinmarketcap. To test this PR with mainnet, check out the branch, set .env valuePUBLIC_NETWORKto1, and populateCOINMARKETCAP_API_KEYwith your own key.This is largely re-using the existing API surface of the
fiat-estimatesutil, in order to keep the door open to bring back real-time (or periodic) price updates in the future.All Coinmarketcap API calls are proxied through our SvelteKit backend. On call to
fiatEstimates.start, the app fetches a map of ERC-20 token addresses to Coinmarketcap IDs, which is a lot safer than relying on symbols, the uniqueness of which is not guaranteed. On call totrack, it now fetches the current USD value of the given tokens once. There's currently no logic for updating currently-tracked tokens over time, but we can bring this back in the future while keeping the current API surface.