-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create multiple drip lists, list as grid of linked card-thumbs (closes #694, closes #695, closes #697) #701
Merged
efstajas
merged 7 commits into
feature/multi-drip-list
from
feature/multi-drip-list__ev/drip-card-thumb
Oct 2, 2023
Merged
create multiple drip lists, list as grid of linked card-thumbs (closes #694, closes #695, closes #697) #701
efstajas
merged 7 commits into
feature/multi-drip-list
from
feature/multi-drip-list__ev/drip-card-thumb
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efstajas
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
amazing 🔥
evvvritt
added a commit
that referenced
this pull request
Oct 9, 2023
…loses #697) (#701) * feat: drip-card thumblink format * style: drip-list-card thumb truncates to max 4 split rows * feat: allow creating multiple drip lists :) * style: drip-list-card mobile header (no horizontal scroll on single view) * style: create new drip list card * style: touchup drip-list-cards on profile * style: drip list card: truncate
efstajas
added a commit
that referenced
this pull request
Oct 26, 2023
* feat: show multiple drip lists, introduce visibleDripListAccountIds in metadata * create multiple drip lists, list as grid of linked card-thumbs (closes #694, closes #695, closes #697) (#701) * feat: drip-card thumblink format * style: drip-list-card thumb truncates to max 4 split rows * feat: allow creating multiple drip lists :) * style: drip-list-card mobile header (no horizontal scroll on single view) * style: create new drip list card * style: touchup drip-list-cards on profile * style: drip list card: truncate title only on thumblink format * style: create multiple lists, list as grid (closes #694, closes #695, closes #697) (#701) * feat: drip-card thumblink format * style: drip-list-card thumb truncates to max 4 split rows * feat: allow creating multiple drip lists :) * style: drip-list-card mobile header (no horizontal scroll on single view) * style: create new drip list card * style: touchup drip-list-cards on profile * style: drip list card: truncate * feat: no longer block multiple drip lists in creation flow * feat: #712 (#752) * feat: #712 * feat: add modal icon to new step * fix: incorrect representational splits for add-drip-list-member flow * fix: support-card blocks after a single drip list is supporting * fix: possible to add same thing to list multiple times * feat: make drip list icon grey if disabled * feat: bump max-height of drip list selector * fix: drip list icons in selector are links (it's weird) * feat: stable drip lists view (#753) * feat: stable drip lists view * style: remove leftover comment * feat: display desc on dl listing again, while remaining stable * feat: tweak layout * fix: tooltips on lists broken * feat: improve layout * feat: go to single drip list view after creation * test: use fake-pinata service, adjust tests for multi-drip list * chore: clean up unused prop * chore: remove overlooked comment * test: organize tests * fix: initially collapsed transitioned-height appear uncollapsed * fix: text-expandable not collapsing text * test: remove obsolete tests for ipfs mocking * ci: remove commitlint * feat: even more stable drip list card layout * remove half-implementation of #698 * fix missing button to create support stream * make support cards sticky (#767) * make support cards sticky, layout improvements * remove unnecessary css attr * fix awkward overflow on streams page * improve breakpoints * wrap dl title and actions if necessary * Ev/support card buttons (closes #768) (#770) * support-card: add stream option for drip list owner * show SupportCard on unclaimed project profiles --------- Co-authored-by: evvvritt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #694, #695, #697