-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drip list support button #705
Conversation
efstajas
commented
Oct 3, 2023
•
edited
Loading
edited
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with minor copy suggestions
{:else} | ||
Add <span class="typo-text-bold">{project.source.repoName}</span> to your Drip List to support | ||
this project. | ||
Add this {project ? 'project' : ''} to your Drip List to flexibly support it with an ongoing contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add this {project ? 'project' : ''} to your Drip List to flexibly support it with an ongoing contribution. | |
Add this {project ? 'project' : ''} to {ownDripList === null ? 'a' : 'your'} Drip List where they will receive a portion of any funds streamed to your list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it sounds weird to use "where" here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"and they will.."
would also do
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's better. But maybe "and it will" since it's referring to the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's referring to the project though (which receives a portion of what goes to the list). 'Become a supporter of the project by adding it to a Drip List'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right this is used on project and drip list pages* So ya maybe a conditional for they/it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works for project and list. Just because it's a project doesn't mean it's multiple people.