Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drip list support button #705

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Conversation

efstajas
Copy link
Contributor

@efstajas efstajas commented Oct 3, 2023

Screenshot 2023-10-03 at 15 07 31

@efstajas efstajas requested a review from evvvritt October 3, 2023 13:04
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for drips-app-v2 ready!

Name Link
🔨 Latest commit 4d8289d
🔍 Latest deploy log https://app.netlify.com/sites/drips-app-v2/deploys/651c142971cc5300083ca7b9
😎 Deploy Preview https://deploy-preview-705--drips-app-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@evvvritt evvvritt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with minor copy suggestions

{:else}
Add <span class="typo-text-bold">{project.source.repoName}</span> to your Drip List to support
this project.
Add this {project ? 'project' : ''} to your Drip List to flexibly support it with an ongoing contribution.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Add this {project ? 'project' : ''} to your Drip List to flexibly support it with an ongoing contribution.
Add this {project ? 'project' : ''} to {ownDripList === null ? 'a' : 'your'} Drip List where they will receive a portion of any funds streamed to your list.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it sounds weird to use "where" here

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"and they will.."
would also do

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that's better. But maybe "and it will" since it's referring to the list.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's referring to the project though (which receives a portion of what goes to the list). 'Become a supporter of the project by adding it to a Drip List'

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right this is used on project and drip list pages* So ya maybe a conditional for they/it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for project and list. Just because it's a project doesn't mean it's multiple people.

@efstajas efstajas merged commit 2b9a897 into main Oct 4, 2023
@efstajas efstajas deleted the jason/drip-list-support-button branch October 4, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants