style: use drip-list-badge in streams table (closes #700) #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for drips-app-v2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
efstajas
requested changes
Oct 4, 2023
There was a problem hiding this comment.
Would be great to make a small version of the drip list badge icon to align it with address stream recipients
Also re. showing the ens / address in the drip list badge, I guess streams always appear in the context of one particular user, so I feel like we could just always hide it in the context of the stream table. Then it'd need to be one boolean prop like showUsername 🤔
|
Ok, simplified things, lmk wyt @efstajas
|
efstajas
requested changes
Oct 4, 2023
efstajas
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #700 (don't see a reason not to just merge this into main?)
(would've been nice to hide the drip list username when in dashboard streams context but seems really hairy to pass that context down to the UserBadgeCell component?)