Support hidden entities #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚅 Previously deployed to Railway in the Drips App project. Environment has been deleted. |
efstajas
requested changes
Dec 3, 2024
| @@ -109,6 +118,9 @@ export default class TransferEventHandler extends EventHandlerBase<'Transfer(add | |||
| dripList.previousOwnerAddress = from; | |||
| dripList.ownerAccountId = await calcAccountId(to); | |||
|
|
|||
| // This is real transfer. The Drip List should not be visible unless the block number is less than the visibility threshold. | |||
| dripList.isVisible = blockNumber < visibilityThresholdBlockNumber; | |||
There was a problem hiding this comment.
doesn't minting a new NFT account produce transfer where from === null address? should this set isVisible to true if from is null address?
There was a problem hiding this comment.
The creation of the drip list (from === ZeroAddress) is covered before in the code.
If the code reaches this point, the list already exists. Makes sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.