Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jaeger deployment to minikube #17

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

jbtrystram
Copy link
Member

@jbtrystram jbtrystram commented Feb 8, 2022

add to minikube.yaml profile :

drogueCloudCore:
  global:
    drogueCloud:
      jaeger:
        enabled: true

drogueCloudMetrics:
  tracing:
    enabled: true

TODO :

  • Revisit the all in one jaeger instance ?
  • Add an Ingress for the jaeger-query UI

@jbtrystram jbtrystram force-pushed the feature/jaeger-minikube branch from f4e0025 to 41d616b Compare February 8, 2022 15:02
@ctron ctron force-pushed the feature/add_tracing_1 branch 3 times, most recently from 902a0ec to f4d180a Compare February 10, 2022 09:38
@jbtrystram jbtrystram force-pushed the feature/jaeger-minikube branch from 41d616b to 1b349d5 Compare February 10, 2022 10:16
@ctron ctron force-pushed the feature/add_tracing_1 branch 2 times, most recently from bd0ed9d to 3a120b7 Compare February 10, 2022 10:45
@jbtrystram jbtrystram changed the title feat: add jaeger tracing configuration Add jaeger deployment to minikube Feb 10, 2022
@jbtrystram jbtrystram force-pushed the feature/jaeger-minikube branch from 1b349d5 to d41c55b Compare February 10, 2022 15:46
@ctron
Copy link
Member

ctron commented Feb 15, 2022

I added the tracing flag (or now actually jaeger flag) to the global section. Which should make it available in all contexts under global. I also renamed it to jaeger since the meaning currently is more "tracing with jaeger".

I was hoping that by doing that, the configuration could become:

global:
  drogueCloud:
    jaeger:
      enabled: false # defaults to false
      deployOperator: true # false for openshift

And, that way, the drogue-cloud-common helm chart could ultimately handle this by providing macros which get called from both drogue-cloud-core and drogue-cloud-twin.

Base automatically changed from feature/add_tracing_1 to main February 15, 2022 12:30
@jbtrystram jbtrystram force-pushed the feature/jaeger-minikube branch from 9bb5614 to cb803da Compare February 16, 2022 10:50
@jbtrystram jbtrystram force-pushed the feature/jaeger-minikube branch 2 times, most recently from 0d9ca31 to a3b3f06 Compare February 16, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants