-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update embassy dependencies #19
Conversation
That's a good question, I've cloned your PR and tried to fix it, but I'm not sure what could be the problem here. This must be some kind of cargo resolving issue, because TBH I don't think the integration tests add any value anymore now that the examples are much easier to run than they used to be. |
happy for me to remove the integration test? |
I think it's ok to remove, they don't add much value and has been a source of annoyance for a long time. |
I might see if it can run in tokio instead first |
no idea! I'll remove and update the PR. |
There's a clippy issue which needs resolving too, it's not in a file we've changed but clippy issues are set as errors. I noticed earlier there's another PR from February which was also aiming to update dependencies, and contains what I now realise is the fix for the clippy issue. Here is the relevant fix: |
Cool, I'll leave it for you to look at when you're back @petekubiak. We can consolidate the bits from the other PRs too I guess. |
Ok I think this is ready for full review now. |
Co-authored-by: James Sizeland <[email protected]>
…y proc_macro feature
This PR updates the embassy dependencies to the latest version, so that ector can be used with the latest version of embassy (without these changes there is a dependency clash with embassy v0.6.0).
We have also removed the
#[feature]
flags which have now been made stable, meaning that the repo as a whole no longer requires the nightly toolchain.An integration test which had broken dependencies has been removed (see discussion below).