This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add context.Context as first parameter to all funcs in Engine interface
Add ports to NetworkMapping for Kubernetes
zetaab
commented
Dec 11, 2018
volume.HostPath = &v1.HostPathVolumeSource{ | ||
Path: vol.HostPath.Path, | ||
Type: &source, | ||
if usePVC { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is difference between vol.HostPath
and vol.EmptyDir
? Do we need persistentvolumeclaim in both?
fix fmt
zetaab
force-pushed
the
implementvolumes
branch
from
December 11, 2018 11:28
77d0976
to
e8488b0
Compare
bradrydzewski
force-pushed
the
master
branch
2 times, most recently
from
January 17, 2019 01:53
9c6da72
to
c8cf505
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19
I am executing this pipeline:
With storageclass (new functionality)
Like you can see steps are executed in different nodes. However, the print is little bit different what it is without persistent volume. Check that
[bar:1] hello.txt
vshello.txt
rows. Any ideas what is causing that?Without storageclass (the behaviour before (and after) this PR)
Anyways now if people have RWX volumes in cluster they can use multiple nodes to build stuff. I installed heketi to my cluster using https://github.com/gluster/gluster-kubernetes and then dynamically provisioning pvcs from it.