This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
Resolve pod could be scheduled by node name. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@bradrydzewski This looks like this will fix an issue we are having with scheduling failing in pods. Any reason it's not yet been merged in? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #72
drone-runtime use node affinity to schedule a pod on the same node, it match the name of node to
kubernetes.io/hostnamelabel. Usually it works well. But ifkubernetes.io/hostnamelabel does not use the name of node it can make a problem.I have resolved by using the node name, it comes from the discourse. Thanks