Merge pull request #326 from drone/atmsn/bb_prauthor

Update Bitbucket PR author login
drone · Nov 19, 2024 · 7dc2e34 · 7dc2e34
2 parents 63abea2 + df65124
commit 7dc2e34
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/scm/driver/bitbucket/pr.go b/scm/driver/bitbucket/pr.go
@@ -193,7 +193,7 @@ func convertPullRequest(from *pr) *scm.PullRequest {
 			Sha:  from.Destination.Commit.Hash,
 		},
 		Author: scm.User{
-			Login:  from.Author.Nickname,
+			ID:     from.Author.AccountID,
 			Name:   from.Author.DisplayName,
 			Avatar: from.Author.Links.Avatar.Href,
 		},

diff --git a/scm/driver/bitbucket/testdata/pr.json.golden b/scm/driver/bitbucket/testdata/pr.json.golden
@@ -22,7 +22,7 @@
       "Name": "Lachlan-Vass/ios-date-picker-component-duplicate-marc-1579222909688"
     },
     "Author": {
-      "Login": "Lachlan",
+      "ID": "5c7c7b1a0b79db7c3e33eca2",
       "Name": "Lachlan Vass",
       "Avatar": "https://avatar-management--avatars.us-west-2.prod.public.atl-paas.net/5c7c7b1a0b79db7c3e33eca2/6b6b8178-0da0-4a37-b0dd-f8b5e3628eaa/128"
     },

diff --git a/scm/driver/bitbucket/testdata/prs.json.golden b/scm/driver/bitbucket/testdata/prs.json.golden
@@ -23,7 +23,7 @@
       "Name": "Lachlan-Vass/ios-date-picker-component-duplicate-marc-1579222909688"
     },
     "Author": {
-      "Login": "Lachlan",
+      "ID": "5c7c7b1a0b79db7c3e33eca2",
       "Name": "Lachlan Vass",
       "Avatar": "https://avatar-management--avatars.us-west-2.prod.public.atl-paas.net/5c7c7b1a0b79db7c3e33eca2/6b6b8178-0da0-4a37-b0dd-f8b5e3628eaa/128"
     },