fix queue potential leak

drpcorg · Sep 6, 2024 · d75b800 · d75b800
1 parent 523476c
commit d75b800
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/utils/queue.go b/utils/queue.go
@@ -62,12 +62,14 @@ func (q *FDQueue[S, E]) Feed() (recs S, err error) {
 		return
 	case <-time.After(q.timeout):
 		return
-	case pkg := <-q.ch:
+	case pkg, ok := <-q.ch:
+		if !ok {
+			return
+		}
 		recs = append(recs, pkg)
-		for ok := false; ok; {
-			pkg, ok = <-q.ch
-			recs = append(recs, pkg)
+		if len(q.ch) == 0 {
+			return
 		}
-		return
 	}
+	return
 }