-
Notifications
You must be signed in to change notification settings - Fork 201
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(APQ): Fix APQ with page caches (#1317)
- Loading branch information
Showing
4 changed files
with
195 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
151 changes: 151 additions & 0 deletions
151
tests/src/Kernel/Framework/AutomaticPersistedQueriesDynamicPageCacheTest.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,151 @@ | ||
| <?php | ||
|
|
||
| namespace Drupal\Tests\graphql\Kernel\Framework; | ||
|
|
||
| use Drupal\node\Entity\Node; | ||
| use Drupal\node\Entity\NodeType; | ||
| use Drupal\Tests\graphql\Kernel\GraphQLTestBase; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
|
|
||
| /** | ||
| * Tests the automatic persisted query plugin. | ||
| * | ||
| * @group graphql | ||
| */ | ||
| class AutomaticPersistedQueriesDynamicPageCacheTest extends GraphQLTestBase { | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| protected static $modules = [ | ||
| 'dynamic_page_cache', | ||
| ]; | ||
|
|
||
| /** | ||
| * Test plugin. | ||
| * | ||
| * @var \Drupal\graphql\Plugin\PersistedQueryPluginInterface | ||
| */ | ||
| protected $pluginApq; | ||
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| protected function setUp(): void { | ||
| parent::setUp(); | ||
| $this->configureCachePolicy(); | ||
|
|
||
| $schema = <<<GQL | ||
| schema { | ||
| query: Query | ||
| } | ||
| type Query { | ||
| node(id: String): Node | ||
| } | ||
| type Node { | ||
| title: String! | ||
| id: Int! | ||
| } | ||
| GQL; | ||
| $this->setUpSchema($schema); | ||
| $this->mockResolver('Query', 'node', | ||
| $this->builder->produce('entity_load') | ||
| ->map('type', $this->builder->fromValue('node')) | ||
| ->map('id', $this->builder->fromArgument('id')) | ||
| ); | ||
|
|
||
| $this->mockResolver('Node', 'title', | ||
| $this->builder->produce('entity_label') | ||
| ->map('entity', $this->builder->fromParent()) | ||
| ); | ||
|
|
||
| $this->mockResolver('Node', 'id', | ||
| $this->builder->produce('entity_id') | ||
| ->map('entity', $this->builder->fromParent()) | ||
| ); | ||
|
|
||
| /** @var \Drupal\graphql\Plugin\DataProducerPluginManager $manager */ | ||
| $manager = $this->container->get('plugin.manager.graphql.persisted_query'); | ||
|
|
||
| $this->pluginApq = $manager->createInstance('automatic_persisted_query'); | ||
| } | ||
|
|
||
| /** | ||
| * Test APQ with dynamic page cache. | ||
| * | ||
| * Tests that cache context for different variables parameter is correctly | ||
| * added to the dynamic page cache entries. | ||
| */ | ||
| public function testPageCacheWithDifferentVariables(): void { | ||
| // Before adding the persisted query plugins to the server, we want to make | ||
| // sure that there are no existing plugins already there. | ||
| $this->server->removeAllPersistedQueryInstances(); | ||
| $this->server->addPersistedQueryInstance($this->pluginApq); | ||
| $this->server->save(); | ||
| $endpoint = $this->server->get('endpoint'); | ||
|
|
||
| NodeType::create([ | ||
| 'type' => 'test', | ||
| 'name' => 'Test', | ||
| ])->save(); | ||
|
|
||
| $node = Node::create([ | ||
| 'nid' => 1, | ||
| 'title' => 'Node 1', | ||
| 'type' => 'test', | ||
| ]); | ||
| $node->save(); | ||
|
|
||
| $node = Node::create([ | ||
| 'nid' => 2, | ||
| 'title' => 'Node 2', | ||
| 'type' => 'test', | ||
| ]); | ||
| $node->save(); | ||
|
|
||
| $titleQuery = 'query($id: String!) { node(id: $id) { title } }'; | ||
| $idQuery = 'query($id: String!) { node(id: $id) { id } }'; | ||
|
|
||
| // Post query to endpoint to register the query hashes. | ||
| $parameters['extensions']['persistedQuery']['sha256Hash'] = hash('sha256', $titleQuery); | ||
| $parameters['variables'] = '{"id": "2"}'; | ||
| $content = json_encode(['query' => $titleQuery] + $parameters); | ||
| $request = Request::create($endpoint, 'POST', [], [], [], ['CONTENT_TYPE' => 'application/json'], $content); | ||
| $result = $this->container->get('http_kernel')->handle($request); | ||
| $this->assertSame(200, $result->getStatusCode()); | ||
| $this->assertSame(['data' => ['node' => ['title' => 'Node 2']]], json_decode($result->getContent(), TRUE)); | ||
|
|
||
| $parameters['extensions']['persistedQuery']['sha256Hash'] = hash('sha256', $idQuery); | ||
| $parameters['variables'] = '{"id": "2"}'; | ||
| $content = json_encode(['query' => $idQuery] + $parameters); | ||
| $request = Request::create($endpoint, 'POST', [], [], [], ['CONTENT_TYPE' => 'application/json'], $content); | ||
| $result = $this->container->get('http_kernel')->handle($request); | ||
| $this->assertSame(200, $result->getStatusCode()); | ||
| $this->assertSame(['data' => ['node' => ['id' => 2]]], json_decode($result->getContent(), TRUE)); | ||
|
|
||
| // Execute apq call. | ||
| $parameters['variables'] = '{"id": "1"}'; | ||
| $request = Request::create($endpoint, 'GET', $parameters); | ||
| $result = $this->container->get('http_kernel')->handle($request); | ||
| $this->assertSame(200, $result->getStatusCode()); | ||
| $this->assertSame(['data' => ['node' => ['id' => 1]]], json_decode($result->getContent(), TRUE)); | ||
|
|
||
| // Execute apq call with different variables. | ||
| $parameters['variables'] = '{"id": "2"}'; | ||
| $request = Request::create($endpoint, 'GET', $parameters); | ||
| $result = $this->container->get('http_kernel')->handle($request); | ||
| $this->assertSame(200, $result->getStatusCode()); | ||
| $this->assertSame(['data' => ['node' => ['id' => 2]]], json_decode($result->getContent(), TRUE)); | ||
|
|
||
| // Execute apq call with same parameters, but different query. | ||
| $parameters['extensions']['persistedQuery']['sha256Hash'] = hash('sha256', $titleQuery); | ||
| $parameters['variables'] = '{"id": "2"}'; | ||
| $request = Request::create($endpoint, 'GET', $parameters); | ||
| $result = $this->container->get('http_kernel')->handle($request); | ||
| $this->assertSame(200, $result->getStatusCode()); | ||
| $this->assertSame(['data' => ['node' => ['title' => 'Node 2']]], json_decode($result->getContent(), TRUE)); | ||
|
|
||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters