Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GraphiQL to 3.x #1397

Merged
merged 3 commits into from
May 15, 2024

Conversation

Dobefu
Copy link
Contributor

@Dobefu Dobefu commented Apr 22, 2024

I'll be honest; this started out as me trying to fix the issue where the explorer would be empty upon refreshing the page. It has gotten a little out of hand...

This PR updates GraphiQL to the (as of writing) latest 3.x version. The upgrade does not require any database updates, and previously remembered queries will still be remembered by GraphiQl.

@Kingdutch Kingdutch added the 4.x label May 13, 2024
Copy link
Contributor

@Kingdutch Kingdutch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not had the time to test this functionally but from a code perspective this looks fine to me :)

@Kingdutch Kingdutch requested a review from klausi May 13, 2024 06:55
Copy link
Contributor

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot, works for me in our project.

@klausi klausi merged commit 8a7ffd8 into drupal-graphql:8.x-4.x May 15, 2024
4 checks passed
@Dobefu Dobefu deleted the feature/update-graphiql-to-3.x branch May 24, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants