Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility #6069

Closed
andypost opened this issue Jul 22, 2024 · 15 comments
Closed

PHP 8.4 compatibility #6069

andypost opened this issue Jul 22, 2024 · 15 comments

Comments

@andypost
Copy link
Contributor Author

andypost commented Jul 22, 2024

Using oneliner find . -name '*.php' -exec php -l {} \;

And search in vendor find vendor -name "*.php" -exec sh -c 'php -l "$1" 2>&1 | grep -v "No syntax errors detected in" || true' _ {} \; > php84-vendor.log

php84-vendor.log

andypost added a commit to andypost/config that referenced this issue Jul 22, 2024
andypost added a commit to skilld-labs/site-process that referenced this issue Jul 23, 2024
@andypost
Copy link
Contributor Author

Using official docker image
docker run --rm -v $(pwd):/mnt -w /mnt php:8.4.0alpha2-cli-alpine find src -type f -name '*.php' -exec php -l {} \;

@andypost
Copy link
Contributor Author

andypost commented Jul 23, 2024

Needs update symfony/polyfill-mbstring to 1.30.0 for
symfony/polyfill-mbstring@e5e7ddb
and 1.30.0 for symfony/polyfill-php83@4101e9e

@andypost
Copy link
Contributor Author

also needs upgrade PhpStan but few of its dependencies not yet ready too

greg-1-anderson pushed a commit to consolidation/config that referenced this issue Jul 23, 2024
greg-1-anderson pushed a commit to consolidation/site-process that referenced this issue Jul 23, 2024
greg-1-anderson pushed a commit to consolidation/annotated-command that referenced this issue Jul 23, 2024
greg-1-anderson pushed a commit to consolidation/site-alias that referenced this issue Jul 23, 2024
greg-1-anderson pushed a commit to consolidation/robo that referenced this issue Jul 23, 2024
@andypost
Copy link
Contributor Author

Example use of 8.4 in CI mck89/peast@97dd57f

@weitzman
Copy link
Member

weitzman commented Aug 2, 2024

Thanks for this work, @andypost and @greg-1-anderson. Looks like the dependencies are making progress.

@andypost
Copy link
Contributor Author

Please create new release for consolidation/annotated-command#311

@andypost
Copy link
Contributor Author

andypost commented Oct 3, 2024

new release 3.2.3 is out! for phootwork/phootwork#97 (comment)

@andypost
Copy link
Contributor Author

https://github.com/thephpleague/container/releases/tag/4.2.3 is out so only 1 dependency left

@andypost
Copy link
Contributor Author

All dependencies are ready

@andypost
Copy link
Contributor Author

moreover https://github.com/wodby/php/releases/tag/4.54.0 release is out with PHP 8.4 (no pcov/newrelic)

@weitzman
Copy link
Member

weitzman commented Dec 1, 2024

Can this be closed? AFAIK we did this.

@andypost
Copy link
Contributor Author

andypost commented Dec 1, 2024

More remains found consolidation/site-alias#72

@weitzman
Copy link
Member

This is now complete?

@andypost
Copy link
Contributor Author

I bet it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants