Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.4 compatibility: implicitly nullable parameter declarations deprecated #311

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

andypost
Copy link
Contributor

Ref drush-ops/drush#6069

Disposition

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes
  • Deprecation

Summary

Fixed all nullable type declarations found

Description

Testing with official docker image docker run --rm -v $(pwd):/mnt -w /mnt php:8.4.0alpha2-cli-alpine find src -type f -name '*.php' -exec php -l {} \;

@greg-1-anderson greg-1-anderson merged commit 7025123 into consolidation:4.x Jul 23, 2024
8 checks passed
@andypost andypost deleted the php-84 branch July 23, 2024 17:03
@andypost
Copy link
Contributor Author

@greg-1-anderson please create new release as this is only deprecation appeared in core testing https://git.drupalcode.org/issue/drupal-3427903/-/jobs/2500443

@markmont
Copy link

I'm following this issue since PHP 8.4 has started breaking things for us / our users / customers. Right now we're telling affected people to downgrade to PHP 8.3 in order to use Terminus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants