Selective local check #4156
Open
Selective local check #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MPParsley
approved these changes
Aug 16, 2019
Sutharsan
reviewed
Apr 8, 2020
| $projects = StringUtils::csvToArray($passed_projects); | ||
| } | ||
|
|
||
| // Remove duplicate projects. |
There was a problem hiding this comment.
I'm not fond of documentation that only describes what the code does. If it does not add value, it is an additional maintenance burden.
There was a problem hiding this comment.
basarkar, thanks for contributing this code. I agree that it is an added value to the existing command.
It also needs a test.
There was a problem hiding this comment.
@basarkar, Please explain the purpose of an selective locale:check command if the local:update command is not selective.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the drush 9 version of PR #3601