Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip checks for branch deletions #73

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brianlong2
Copy link

Should fix #71

@drwahl
Copy link
Owner

drwahl commented Apr 18, 2016

Sorry, a nasty bout of illness has had me offline for a few days. I like this PR overall, but I think we should add some logic around the "rm -rf" to ensure we're not somehow accidentally rm-ing /.

# workaround: deleting a branch should skip the checks
if [[ $newrev == "0000000000000000000000000000000000000000" ]]; then
echo "Skipping file checks this is a branch delete..."
rm -rf "$tmptree"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianlong2 It would be much safer to use rmdir instead of rm. With this we avoid problems mentioned by David in comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants