ADDomainController - Added support to demote domain controller - Fixes #251

[limiteddenial]

Pull Request (PR) description

Added support to demote domain controller when ensure is set to Absent.

This Pull Request (PR) fixes the following issues

• Fixes ADDomainController: Add ability to demote DCs with Ensure = Absent #251

Task list

• Added an entry to the change log under the Unreleased section of the
  file CHANGELOG.md. Entry should say what was changed and how that
  affects users (if applicable), and reference the issue being resolved
  (if applicable).
• Resource documentation added/updated in README.md.
• Resource parameter descriptions added/updated in README.md, schema.mof
  and comment-based help.
• Comment-based help added/updated.
• Localization strings added/updated in all localization files as appropriate.
• Examples appropriately added/updated.
• Unit tests added/updated. See DSC Community Testing Guidelines.
• [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #634 (dcfbf87) into main (9346a1d) will increase coverage by 0%.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main   #634   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files        25     25           
  Lines      3408   3435   +27     
===================================
+ Hits       3340   3367   +27     
  Misses       68     68           

[limiteddenial]

Is there anything I can do to help this move forward in the review process?

[X-Guardian]

Hi @limiteddenial, thankyou for your contribution and raising this PR. The current situation with this module is that there is a known issue with the ADGroup resource, #633. Until this is rectified there won't be a new full release of the module, and any time I have available to spend will be on resolving that issue. To be honest, I believe the use cases of demoting a DC through DSC as being very limited, so looking at this will be low priority for me.

Just looking at the CodeCov report, it is saying that 7 lines have been missed in this PR, so in the meantime can you please look at increasing the unit tests to cover these lines.

[stale]

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.