add Landau-Lifschitz-Gilbert (LLG) simulation to magnetization module #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the LL class where the shared functions of LLG and LLB are in. Than I added the LLG class. Running example is provided in the .ipynb |
|
Hi @friweber , thanks for the PR! Before going into detail, there are a lot of files which have changed in your commits (in total 21). Could you please try to revert this and only have the relevant changes in your PR? Best Daniel |
|
Now it should be better. I don't understand why it shows a difference in upload-to-pypi.yml but all other issues are resolved |
dschick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a new LLG class to the magnetization module which also provides a magneto-elastic coupling.