Make excludes more flexible

[ajbeaven]

Apply excludes on the root node modules folder rather than every individual package which allows for more flexibility.

This will potentially break existing installs, so suggest you bump the major version.

[dshemendiuk]

Hi, @ajbeaven
Can you provide an example of a gulp task that works?

It does not work for default tasks from the readme.

[ajbeaven]

Hrm... what's not working?

With a package.json like so:

{
  "name": "thing",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
  },
  "author": "",
  "license": "ISC",
  "devDependencies": {
    "gulp": "^4.0.2",
    "gulp-npm-dist": "^1.0.3"
  },
  "dependencies": {
    "moment": "^2.24.0"
  }
}

And a gulpfile.js like so:

var gulp = require('gulp');
var npmDist = require('gulp-npm-dist');

gulp.task('copy:libs', function () {
    return gulp.src(npmDist({
            copyUnminified: true,
            excludes: ['/**/*.js']
        }), {
            base: './node_modules/'
        })
        .pipe(gulp.dest('./dist/libs'));
});

Here's a zip file of the above test project.

When you run up the project above using the code below, it seems to correctly exclude all js files (leaving nothing but empty folders in the moment package referenced above):

> npm install
> gulp copy:libs

Using excludes: ['/**/ender.js'] also correctly excludes just that one file.

[dshemendiuk]

Using excludes: ['/**/ender.js'] also correctly excludes just that one file.

But it crashes without excludes option

[ajbeaven]

Works fine on my machine... can you give more details? What error message do you get?

[dshemendiuk]

Looks like I have found where the problem was.
Fixed on the latest master.

In truth, I don't like the idea to set up an excludes always with extra asterisks.
But I understand the problem.

[ajbeaven]

I think it makes a lot more sense. It is unexpected to have the excludes be applied on a per-package basis IMO.

I see the most common use case being that you want to exclude a particular file or set of files in a particular package. With the current iteration, that's not made easy.