Fix volume attachment with dstack backend (#2175)

Fixes: #2172 See: #2172 See: #1682
dstackai · Jan 6, 2025 · 163298e · 163298e
1 parent edec92d
commit 163298e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/src/dstack/_internal/server/background/tasks/process_submitted_jobs.py b/src/dstack/_internal/server/background/tasks/process_submitted_jobs.py
@@ -546,7 +546,7 @@ async def _attach_volumes(
             volume = volume_model_to_volume(volume_model)
             try:
                 if (
-                    job_provisioning_data.backend != volume.configuration.backend
+                    job_provisioning_data.get_base_backend() != volume.configuration.backend
                     or job_provisioning_data.region != volume.configuration.region
                 ):
                     continue

diff --git a/src/dstack/_internal/server/services/jobs/__init__.py b/src/dstack/_internal/server/services/jobs/__init__.py
@@ -95,6 +95,8 @@ def job_model_to_job_submission(job_model: JobModel) -> JobSubmission:
         job_provisioning_data.instance_type.resources.description = (
             job_provisioning_data.instance_type.resources.pretty_format()
         )
+        # TODO do we really still need this magic? See https://github.com/dstackai/dstack/pull/1682
+        # i.e., replacing `jpd.backend` with `jpd.get_base_backend()` should give the same result
         if (
             job_provisioning_data.backend == BackendType.DSTACK
             and job_provisioning_data.backend_data is not None

diff --git a/src/dstack/_internal/server/services/runs.py b/src/dstack/_internal/server/services/runs.py
@@ -844,7 +844,7 @@ def get_job_mount_point_volume(
     """
     for volume in volumes:
         if (
-            volume.configuration.backend != job_provisioning_data.backend
+            volume.configuration.backend != job_provisioning_data.get_base_backend()
             or volume.configuration.region != job_provisioning_data.region
         ):
             continue