Allow getting by ID in /api/project/_/fleets/get
#2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r4victor
reviewed
Jan 20, 2025
| async def get_fleet_by_name( | ||
| session: AsyncSession, project: ProjectModel, name: str | ||
| async def get_fleet( | ||
| session: AsyncSession, project: ProjectModel, name: Optional[str], id: Optional[uuid.UUID] |
There was a problem hiding this comment.
id local variable shadows a Python's built-in. Alternatives: fleet_id or id_
There was a problem hiding this comment.
The id built-in is rarely used, and using id as a parameter name allows for a more concise function signature. But I think some IDEs and linters don't like it when built-ins are shadowed, so I'll rename it.
|
I suppose it should also handle backward compatibility for new clients with old servers similar to this fix #2174 |
r4victor
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2133