Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] New UI for fleets and instances #2236

Merged
merged 7 commits into from
Jan 30, 2025
Merged

[UI] New UI for fleets and instances #2236

merged 7 commits into from
Jan 30, 2025

Conversation

olgenn
Copy link
Collaborator

@olgenn olgenn commented Jan 27, 2025

Close #2133

@olgenn olgenn self-assigned this Jan 27, 2025
@olgenn olgenn changed the title [UI] New UI for fleets and instances #2133 [UI] New UI for fleets and instances Jan 27, 2025
Copy link
Collaborator

@jvstme jvstme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olgenn, thanks for the PR! I tested the new pages and they work as expected except for a few issues. I'll list them below.

Major:

  1. The Instances list page fails to load if there are any pending instances. Console error: React Router caught the following error during render TypeError: item.instance_type is null.

    not-loaded-when-pending.mp4
  2. The pagination seems to be off in the Instances list and Fleets list pages. If I open the second page and then return to the first page, it looks different than when I first opened it. If I then go through the pages again, it shows three pages, although at first there were only two.

    pagination.mp4

Not major, can be finished after merging this PR:

  1. On the Fleets list and Fleet details pages, we won't need the Backend, Region, and Spot fields. The Price field should be calculated as the sum of non-terminated instance prices. And we also need the Instances field with a summary of non-terminated fleet instances. Please see the design document for a detailed specification of the desired fields.
  2. We'd also like to show terminated fleets on the Fleets list page. Maybe add an "Active fleets" trigger?
  3. The document also requests a "Delete" button on the Fleet details page.
  4. The document also requests links to fleet details in the "Fleet" field of the Instances list page.
  5. Can we also add links to project settings in the "Project" field of the Instances list page?
  6. If the instance costs 0, its price on the Instances list page is shown without a dollar sign. Can we add the dollar sign?
    zero-price

Copy link
Collaborator

@jvstme jvstme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@olgenn olgenn merged commit 57a14d4 into master Jan 30, 2025
5 checks passed
@olgenn olgenn deleted the 2133_new_fleets branch January 30, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] New UI for fleets and instances
2 participants