Merge pull request #261 from squat/literalidentity

pygam/{core,pygam}: fix literal identity check
dswah · Jul 15, 2020 · 2323eb7 · 2323eb7
2 parents 2942579 + 684ddb6
commit 2323eb7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pygam/core.py b/pygam/core.py
@@ -54,7 +54,7 @@ class name
 
         # flatten sub-term properties, but not `terms`
         k, v = param_kvs.pop()
-        if flatten_attrs and k is not 'terms':
+        if flatten_attrs and k != 'terms':
             v = flatten(v)
 
         # round the floats first

diff --git a/pygam/pygam.py b/pygam/pygam.py
@@ -222,7 +222,7 @@ def _validate_params(self):
                              .format(self.fit_intercept.__class__))
 
         # terms
-        if (self.terms is not 'auto') and not (isinstance(self.terms, (TermList, Term, type(None)))):
+        if (self.terms != 'auto') and not (isinstance(self.terms, (TermList, Term, type(None)))):
             raise ValueError('terms must be a TermList, but found '\
                              'terms = {}'.format(self.terms))
 
@@ -273,7 +273,7 @@ def _validate_data_dep_params(self, X):
         n_samples, m_features = X.shape
 
         # terms
-        if self.terms is 'auto':
+        if self.terms == 'auto':
             # one numerical spline per feature
             self.terms = TermList(*[SplineTerm(feat, verbose=self.verbose) for feat in range(m_features)])