Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #2691 vx_config_tmp_files #2692

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Sep 25, 2023

Expected Differences

These are changes to the develop branch for inclusion in version 12.0.0. Recommend asking NOAA whether or not these same changes should be provided as a bugfix for the main_v11.1 branch.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran this GHA testing workflow to confirm that the changes work as expected. Note that this was for the feature_2690_tmp_files prior to me renaming this branch for a new Eliminate the use of temporary files in the vx_config library #2691 issue. Also note that the diff failure is not related.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the code changes.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    I made no changes to the documentation but do plan to do so for the Document the use of temporary files in MET and reduce it as much as reasonably possible #2690 issue.

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

However, differences in PBL values derived by PB2NC may still be present, as described in #2687.

  • Please complete this pull request review by [Wed 9/27/23].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@JohnHalleyGotway JohnHalleyGotway added this to the MET 12.0.0 milestone Sep 25, 2023
Copy link
Collaborator

@jprestop jprestop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code changes and ensure all tests passed, except for the unrelated difference in the Check for Differences. I approve this PR. Since no forms for the METplus-5.1.0 coordinated release have been submitted for installation on WCOSS2 yet, I would recommended we make this change as a bugfix to main_v11.1 branch so that WCOSS2 users can benefit from this improved timing.

@JohnHalleyGotway JohnHalleyGotway merged commit f72d85d into develop Sep 27, 2023
52 of 54 checks passed
@JohnHalleyGotway JohnHalleyGotway linked an issue Sep 27, 2023 that may be closed by this pull request
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Eliminate the use of temporary files in the vx_config library
2 participants