Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature #3000 point2grid_warning #3001

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Oct 21, 2024

Expected Differences

Change 9 instances of point2grid warning messages to the default level of Debug(2) log messages. Warning messages are retained when the geostationary data file cannot be written and for unexpected lat/lon differences when computing the grid mapping file.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Ran this command on seneca to get a warning since -goes_qc 123 won't match anything:

export 'MET_TMP_DIR=${MET_TEST_OUTPUT}/point2grid'
/d1/projects/MET/MET_regression/develop/NB20241021/MET-develop/bin/point2grid \
      /d1/projects/MET/MET_test_data/unit_test/model_data/goes_16/OR_ABI-L2-AODC-M6_G16_s20241100001171_e20241100003544_c20241100006242.nc \
      G212 \
      /d1/personal/johnhg/MET/MET_development/MET-feature_3000_point2grid_warning/internal/test_unit/../../test_output/point2grid/point2grid_GOES_16_ADP_Enterprise_high.nc \
      -field 'name="AOD_Smoke";  level="(*,*)";' \
      -adp /d1/projects/MET/MET_test_data/unit_test/model_data/goes_16/OR_ABI-L2-ADPC-M6_G16_s20241100001171_e20241100003544_c20241100006361.nc \
      -goes_qc 123 -method MAX \
      -v 2

Here's the output:

WARNING: 
WARNING: regrid_goes_variable() -> No valid data!
WARNING: 
DEBUG 2: Range of data (name="AOD_Smoke";  level="(*,*)";)
DEBUG 2: 	input: -0.05 to 4.99997	regridded: -9999 to -9999.

Rerun using /d1/personal/johnhg/MET/MET_development/MET-feature_3000_point2grid_warning/internal/test_unit/../../share/met/../../bin/point2grid to produce this log output with no warning messages instead:

DEBUG 2: regrid_goes_variable() -> No valid data!
DEBUG 2: Range of data (name="AOD_Smoke";  level="(*,*)";)
DEBUG 2: 	input: -0.05 to 4.99997	regridded: -9999 to -9999.
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Confirm GHA tests run without error and no diffs are flagged.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
    None needed.

  • Do these changes include sufficient testing updates? [No]
    None needed.

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [Not expected]

    If yes, please describe:

  • Please complete this pull request review by [Wed 10/23/24].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…mize the number of warning messages Point2Grid writes. However, do retain the warnings about problems writing the grid mapping output file.
@JohnHalleyGotway JohnHalleyGotway added this to the MET-12.0.0 milestone Oct 21, 2024
@JohnHalleyGotway JohnHalleyGotway linked an issue Oct 21, 2024 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@hsoh-u hsoh-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve the changes.
I reviewed the code changes and no flags from automated testings.

@JohnHalleyGotway JohnHalleyGotway marked this pull request as ready for review October 21, 2024 22:44
@JohnHalleyGotway JohnHalleyGotway merged commit a3142a1 into develop Oct 21, 2024
40 checks passed
@JohnHalleyGotway JohnHalleyGotway deleted the feature_3000_point2grid_warning branch October 21, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Eliminate Point2Grid warning when no valid output data is found
2 participants