Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix #3020 main_v12.0 grid_stat_seeps #3022

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

JohnHalleyGotway
Copy link
Collaborator

Same as PR #3021 but for main_v12.0 instead of develop. Please review this one at the same time as #3021.

Copy link
Contributor

@j-opatz j-opatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation changes look good, and testing already performed appears to show the bug is fixed. Only failed checks are SonarQube and difference checks, both of which are expected.

@JohnHalleyGotway JohnHalleyGotway merged commit c691e02 into main_v12.0 Nov 20, 2024
38 of 40 checks passed
JohnHalleyGotway added a commit that referenced this pull request Nov 22, 2024
… GridStatConfig_SEEPS config file needs to be updated with nc_pairs_flag.seeps = TRUE in order for the same output to be produced by the unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix Grid-Stat segfault when SEEPS is the only NetCDF output type requested
2 participants